On Fri, Nov 01, 2024 at 02:34:31PM +0900, Damien Le Moal wrote: > > - bytes = ALIGN_DOWN(bytes, lim->logical_block_size); > > + bytes = ALIGN_DOWN(bytes, lim->zone_write_granularity ? > > + lim->zone_write_granularity : lim->logical_block_size); > > Nit: we could also do: > > bytes = ALIGN_DOWN(bytes, > max(lim->logical_block_size, lim->zone_write_granularity)); That's what I had first. It is a little odd as zone_write_granularity is defined to be >= logical_block_size, though. > Also, I wonder if we should leave read split as is based on the logical block > size only ? Probably does not matter much... Good point. Probably doesn't matter much, but randomly forcing it on reads seems odd.