On 30.10.24 06:19, Christoph Hellwig wrote: > Hi Jens, > > when porting my zoned XFS code I ran into a regression in > __bio_iov_iter_get_pages 6.12, which isn't all that surprising given that > this path isn't used upstream. After spending some time trying to fix it > I gave up and ported my code to the scheme used in btrfs where the file > system splits bios to the hardware boundaries, which more closely mirror > what we do for the "normal" bio path. > > Either way we should not carry dead code, so patch 1 removes that. > Patch 2 also removes our other zone append helper as for the same reason > no one but semi-passthrough interfaces like nvmet should use it, and > those can simply use bio_add_pc_page. IIRC this code was once used by the zone-append code we where using in zonefs, but that code has been ripped out, so. Looks good, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
