On 10/30/24 06:47, Christoph Hellwig wrote: > On Wed, Oct 30, 2024 at 07:30:49AM +0000, Chaitanya Kulkarni wrote: >> if that is true should we just use the bio_add_hw_page() ? since >> bio_add_pc_page() is a simple wrapper over bio_add_hw_page() without >> the additional checks present in bio_add_zone_append_page() ? > bio_add_hw_page is currently static. But just renaming bio_add_pc_page > to bio_add_hw_page and finding a different name for the version with > the same_page argument sounds like a good idea, but that's for a follow > on patch. I can look into that. > sounds like a plan, looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck
