On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: > > I was following the existing practice exemplified by > bioset_create_nobvec(). Which is pretty ugly to start with.. > By not changing the signature of the function, I can avoid touching > quite a few places where it is called. There are 13 callers of bioset_create and one caller of bioset_create_nobvec, and your series touches many of those. So just adding a flags argument to bioset_create and passing BIOSET_NEED_BVECS and BIOSET_NEED_RESUER flags to it doesn't seem to much of an effort, and it's going to create a much nicer and easier to extend interface.
