On Thu, Apr 20, 2017 at 03:38:48PM +1000, NeilBrown wrote: > This patch converts bioset_create() and > bioset_create_nobvec() to not create a workqueue so > alloctions will never trigger punt_bios_to_rescuer(). It > also introduces bioset_create_rescued() and > bioset_create_nobvec_rescued() which preserve the old > behaviour. Why these super-early line breaks in the committ message? They make the text much more awkware compared to say: This patch converts bioset_create() and bioset_create_nobvec() to not create a workqueue so alloctions will never trigger punt_bios_to_rescuer(). It also introduces bioset_create_rescued() and bioset_create_nobvec_rescued() which preserve the old behaviour. > static struct bio_set *__bioset_create(unsigned int pool_size, > unsigned int front_pad, > - bool create_bvec_pool) > + bool create_bvec_pool, > + bool create_rescue_workqueue) I'd much prefer a single new bioset_create with a bunch of flags arguments over the number of new functions and these bool arguments.
