On Fri, Oct 25, 2024 at 09:43:04PM +0100, John Garry wrote: > On 25/10/2024 12:58, Christoph Hellwig wrote: >> + /* check that the data layout matches the hardware restrictions */ >> + ret = bio_split_rw_at(bio, lim, &nsegs, lim->max_hw_sectors); > > eh, but doesn't bio_split_rw_at() accept bytes (and not a value in sectors) > for max size? Yes. Thanks for the careful review, I've sent out a new version. (and this really helped me finding a bug I had been debugging in another user of this helper :))