On 9/17/24 7:14 AM, Christoph Hellwig wrote: > On Tue, Sep 17, 2024 at 07:11:22AM -0600, Jens Axboe wrote: >> Whatever reshuffling people have in mind, that needs to happen AFTER >> this bug is sorted out. > > Yes. The fix from Damien will work, but reverting to the old behavior > of ignoring the request_module return value feel much better. I can > prepare a patch, but I didn't want to steal the credits from Damien. Oh I agree, I think we should just ignore that and that would be the better patch. My point is just that larger reworking should be done after the fix, not advocating for a particular solution. That said, someone did just email me privately because they ran into this with 6.11. So we should do a clean simple patch to help facilitate getting it to -stable sooner rather than later. -- Jens Axboe