On 9/17/24 7:05 AM, Christoph Hellwig wrote: > On Tue, Sep 17, 2024 at 09:02:36PM +0800, Ming Lei wrote: >> >> Here 'no_freeze' means that automatic 'freeze queue' isn't needed, or >> it can be named as 'no_auto_freeze'. >> >> Again, 'load_module' is one bad name from interface viewpoint, which is just >> needed by 'scheduler' only. > > If we want to reshuffle this we could have a ->store_unfrozen method > that does all the work. But as long as the elevator loading is the > only thing that needs do to unfrozen work I'd just keep things as it > and not rock the boat. Whatever reshuffling people have in mind, that needs to happen AFTER this bug is sorted out. -- Jens Axboe