On Fri, Aug 9, 2024 at 2:58 PM Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > On Fri, Aug 9, 2024 at 8:42 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote: > > > > Dash has ascii value 45 and underscore has ascii value 95, so to > > correctly sort the includes, the underscore should be last. > > > > Fixes: 3253aba3408a ("rust: block: introduce `kernel::block::mq` module") > > Looks good to me (`LC_ALL=C`), thanks! > > I can take it; otherwise: > > Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx> > > I am not sure if this should count as a bug/fix (there is an > recent/ongoing debate about the Fixes tag). I fix merge conflicts in this file almost daily, so I think there's a case to be made for taking it as a fix. I should have clarified this in my commit message. I sent a v2 with more info: https://lore.kernel.org/r/20240809132835.274603-1-aliceryhl@xxxxxxxxxx > (This kind of issues can be also opened as "good first issues", by the > way, i.e. as a way to get contributors to set their email workflow.) I didn't think of that, but if I had I would probably still have submitted it myself for the above reason. Alice