On 8/9/24 8:42 AM, Alice Ryhl wrote:
Dash has ascii value 45 and underscore has ascii value 95, so to
correctly sort the includes, the underscore should be last.
Fixes: 3253aba3408a ("rust: block: introduce `kernel::block::mq` module")
I don't think this patch needs a "Fixes" tag, it's usually for bugs only.
But it still makes sense to mention the commit that introduced the include
in the commit message.
Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Generally speaking, unless minor style issues cause compiler or linter warnings,
I think it's better to leave them alone in favor of not messing with git-blame.
In this case we're not hiding something relevant though, hence
Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
---
rust/bindings/bindings_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index b940a5777330..ae82e9c941af 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -7,8 +7,8 @@
*/
#include <kunit/test.h>
-#include <linux/blk_types.h>
#include <linux/blk-mq.h>
+#include <linux/blk_types.h>
#include <linux/blkdev.h>
#include <linux/errname.h>
#include <linux/ethtool.h>
