Re: [PATCH v2 09/12] block: Use enum to define RQF_x bit indexes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/07/2024 19:13, Bart Van Assche wrote:
On 7/11/24 1:23 AM, John Garry wrote:
+enum {
+    /* drive already may have started this one */
+    __RQF_STARTED        =    0,

Why " = 0"?

As before. I can drop it.

I think this is redundant and can be left out.
Additionally, this enum definition would be easier to read if the
comments would start next to "," instead of occurring on a line of
their own.

ok, I can put the comment next to the value in cases where we will not spill over 80 characters.






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux