On 6/24/24 11:00, Daniel Wagner wrote:
On Mon, Jun 24, 2024 at 10:47:05AM GMT, Christoph Hellwig wrote:
Do you think we should introduce a new type or just use the existing
managed_irq for this?
No idea really. What was the reason for adding a new one?
I've added the new type so that the current behavior of spreading the
queues over to the isolated CPUs is still possible. I don't know if this
a valid use case or not. I just didn't wanted to kill this feature it
without having discussed it before.
But if we agree this doesn't really makes sense with isolcpus, then I
think we should use the managed_irq one as nvme-pci is using the managed
IRQ API.
I'm in favour in expanding/modifying the managed irq case.
For managed irqs the driver will be running on the housekeeping CPUs
only, and has no way of even installing irq handlers for the isolcpus.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
