Re: [PATCH blktests] dm/002: do not assume 512 byte block size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/24/24 19:51, Shin'ichiro Kawasaki wrote:
> The test case assumes that TEST_DEV would have 512 byte block size
> always. However, TEST_DEV may have non 512 byte, 4k block size. In that
> case, the test case fails with I/O errors.
>
> To avoid the errors, refer to the block size of TEST_DEV. Also record
> dd command output to the FULL file to help debug work in the future.
>
> Reported-by: Christoph Hellwig <hch@xxxxxx>
> Fixes: 7308e11c595a ("tests/dm: add dm-dust general functionality test")
> Link: https://lore.kernel.org/linux-block/ZmqrzUyLcUORPdOe@xxxxxxxxxxxxx/
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---
>   

this patch follows the discussion on  the other thread to replace the
hardcoded 512 block size with device's block size with the help of
blockdev --getsz.

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck







[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux