Re: [PATCHv4 blktests] nvme: add test for creating/deleting file-ns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tested this patch, with and without the below fix, and observing expected results.

https://lore.kernel.org/all/20240613164246.75205-1-kbusch@xxxxxxxx/

Tested-by: Venkat Rao Bagalkote <venkat88@xxxxxxxxxxxxxxxxxx>

Regards,
Venkat.
On 20/06/24 12:10 pm, Nilay Shroff wrote:

On 6/20/24 12:05, Daniel Wagner wrote:
On Wed, Jun 19, 2024 at 10:55:02PM GMT, Nilay Shroff wrote:
+		truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
+		uuid="$(uuidgen -r)"
This adds a new dependency on an external tool. It should be mentioned
in the README and added to the list of tools to check for:
_check_dependencies(). Alternatively you could skip the test if the tool
is not available. Anyway the rest looks good.

The "uuidgen" is part of util-linux package and I saw that it's already mentioned
as one of the required packages for blktest: https://github.com/osandov/blktests

Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>

Thanks,
--Nilay




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux