On Wed, Jun 19, 2024 at 10:55:02PM GMT, Nilay Shroff wrote: > + truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i" > + uuid="$(uuidgen -r)" This adds a new dependency on an external tool. It should be mentioned in the README and added to the list of tools to check for: _check_dependencies(). Alternatively you could skip the test if the tool is not available. Anyway the rest looks good. Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>