On Wed, Jun 19, 2024 at 03:58:37PM +0800, Ming Lei wrote: > > > unsigned int bs_mask = queue_logical_block_size(q) - 1; > > > > Please avoid use of the queue helpers. This should be: > > > > unsigned int bs_mask = bdev_logical_block_size(bio->bi_bdev); > > It is one blk-mq internal helper, I think queue helper is more > efficient since it is definitely in fast path. Does it actually generate different code for you with all the inlining modern compilers do?
