On Wed, Jun 19, 2024 at 12:33:49AM -0700, Christoph Hellwig wrote:
> On Wed, Jun 19, 2024 at 01:22:27PM +0900, Damien Le Moal wrote:
> > static bool bio_unaligned(const struct bio *bio,
> > const struct request_queue *q)
> > {
> > unsigned int bs_mask = queue_logical_block_size(q) - 1;
>
> Please avoid use of the queue helpers. This should be:
>
> unsigned int bs_mask = bdev_logical_block_size(bio->bi_bdev);
It is one blk-mq internal helper, I think queue helper is more
efficient since it is definitely in fast path.
Thanks,
Ming
