On 6/17/24 10:07 AM, Steven Rostedt wrote:
On Mon, 17 Jun 2024 10:02:48 -0700
Bart Van Assche <bvanassche@xxxxxxx> wrote:
Do we really want to include the constant "[0]" in the tracing output?
This is how it is printed in the source code.
From the code flow point of view, there is no need to print this value
in trace_block_rq_requeue.
Do we need to consider the issue of uniform printing format? If not, I
think we can delete it.
I'm not aware of any other tracing statement that prints out a constant.
Is there perhaps something that I'm missing or overlooking?
The only time that is done, is if the trace event is used in multiple
places and there's one place that the value will always be the same.
Thanks for the clarification Steven.
Hence:
Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
