On Wed, Apr 24, 2024 at 04:59:46PM +0900, Shin'ichiro Kawasaki wrote: > Some of the test cases in nvme test group can be run under various nvme > target transport types. The configuration parameter nvme_trtype > specifies the transport to use. But this configuration method has two > drawbacks. Firstly, the blktests check script needs to be invoked > multiple times to cover multiple transport types. Secondly, the test > cases irrelevant to the transport types are executed exactly same > conditions in the multiple blktests runs. > > To avoid the drawbacks, allow setting multiple transport types. Taking > this chance, rename the parameter from nvme_trtype to NVMET_TRTYPES to > follow the uppercase letter naming guide for environment variables. > NVMET_TRTYPES can take multiple transport types like: > > NVMET_TRTYPES="loop tcp" > > Introduce _nvmet_set_nvme_trtype() which can be called from the > set_conditions() hook of the transport type dependent test cases. > Blktests will repeat the test case as many as the number of elements in > NVMET_TRTYPES, and set nvme_trtype for each test case run. > > Also introduce _NVMET_TRTYPES_is_valid() to check NVMET_TRTYPES value > before test run. > > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> Reviewed-by: Daniel Wagner <dwagner@xxxxxxx>
