On 3/29/24 06:38, Bart Van Assche wrote: > On 3/27/24 5:43 PM, Damien Le Moal wrote: >> + /* >> + * Remember the capacity of the first sequential zone and check >> + * if it is constant for all zones. >> + */ >> + if (!args->zone_capacity) >> + args->zone_capacity = zone->capacity; >> + if (zone->capacity != args->zone_capacity) { >> + pr_warn("%s: Invalid variable zone capacity\n", >> + disk->disk_name); >> + return -ENODEV; >> + } > > SMR disks may have a smaller last zone. Does the above code handle such > SMR disks correctly? SMR drives known to have a smaller last zone have a smaller conventional zone, not a sequential zone. But good point, I will handle that on the check for conventional zones. > > Thanks, > > Bart. -- Damien Le Moal Western Digital Research