Re: [PATCH blktests 1/2] block/011: recover test target devices to online or live status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 29, 2023 / 10:05, Bart Van Assche wrote:
> On 11/29/23 02:31, Shin'ichiro Kawasaki wrote:
> > +	if [[ -r $TEST_DEV_SYSFS/device/state ]]; then
> > +		state=$(cat "$TEST_DEV_SYSFS/device/state")
> 
> Why the separate -r test and cat instead of this?
> 
> state=$({ cat "$TEST_DEV_SYSFS/device/state"; } 2>/dev/null)

Thanks Bart, this looks the better. Will reflect this change.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux