Re: [PATCH blktests 1/2] block/011: recover test target devices to online or live status

To: "Shin'ichiro Kawasaki" <shinichiro.kawasaki@xxxxxxx>, linux-block@xxxxxxxxxxxxxxx
Subject: Re: [PATCH blktests 1/2] block/011: recover test target devices to online or live status
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Wed, 29 Nov 2023 10:05:11 -0800
Cc: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
In-reply-to: <20231129103145.655612-2-shinichiro.kawasaki@wdc.com>
References: <20231129103145.655612-1-shinichiro.kawasaki@wdc.com> <20231129103145.655612-2-shinichiro.kawasaki@wdc.com>
User-agent: Mozilla Thunderbird

On 11/29/23 02:31, Shin'ichiro Kawasaki wrote:

+	if [[ -r $TEST_DEV_SYSFS/device/state ]]; then
+		state=$(cat "$TEST_DEV_SYSFS/device/state")


Why the separate -r test and cat instead of this?

state=$({ cat "$TEST_DEV_SYSFS/device/state"; } 2>/dev/null)

Thanks,

Bart.

Follow-Ups:
- Re: [PATCH blktests 1/2] block/011: recover test target devices to online or live status
  - From: Shinichiro Kawasaki

References:
- [PATCH blktests 0/2] improve block/011
  - From: Shin'ichiro Kawasaki
- [PATCH blktests 1/2] block/011: recover test target devices to online or live status
  - From: Shin'ichiro Kawasaki