On Fri, Jun 16, 2023 at 12:02 AM Christoph Hellwig <hch@xxxxxx> wrote: > > On Thu, Jun 15, 2023 at 06:55:36AM -0700, Bart Van Assche wrote: > > On 6/14/23 21:15, Christoph Hellwig wrote: > >> I really hate having this core complexity, but I suspect trying to driver > >> hacks would be even worse than that, especially as this goes through > >> the SCSI midlayer. I think the answer is simply that if Google keeps > >> buying broken hardware for their products from Samsung they just need > >> to stick to a 4k page size instead of moving to a larger one. > > > > Although I do not like it that the Exynos UFS controller does not follow > > the UFS standard, this UFS controller is used much more widely than only in > > devices produced by my employer. See e.g. the output of the following grep > > command: > > But it seems like no one is insisting on using it with larger than 4k > page sizes. I think we should just prohibit using the driver for those > kernel configs and be done with it. In addition to Google, Samsung and MediaTek and other vendors have devices that want to take advantage of 16k page size support and they use the same Exynos UFS host controller. For example, these phones could potentially support 16k page sizes: Samsung Galaxy A54 5G, Exynos 1380 Samsung Galaxy A14 5G, Exynos 1330 See https://semiconductor.samsung.com/us/processor/showcase/smartphone/