On Wed, Jun 14, 2023 at 08:22:31PM -0600, Jens Axboe wrote: > I'm usually a fan of putting code in the core so we don't have to in > drivers, that's how most of the block layer is designed. But this seems > niche enough that perhaps it's worth considering just remapping these in > the driver? It's peppering changes all over delicate parts of the core > for cases that 99.9% don't need to worry about or should worry about. > I will say that I do think the patches do look better than they did in > earlier versions, however. > > Maybe we've already discussed this before, but let's please have the > discussion again. Because I'd really love to avoid this code, if at all > possible. I really hate having this core complexity, but I suspect trying to driver hacks would be even worse than that, especially as this goes through the SCSI midlayer. I think the answer is simply that if Google keeps buying broken hardware for their products from Samsung they just need to stick to a 4k page size instead of moving to a larger one.
