Hi Geert,
On 15/06/23 19:21, Geert Uytterhoeven wrote:
Hi Michael,
Thanks for your patch!
On Thu, Jun 15, 2023 at 7:53 AM Christoph Hellwig <hch@xxxxxx> wrote:
On Thu, Jun 15, 2023 at 04:50:45PM +1200, Michael Schmitz wrote:
And as far as I can tell everything that is a __u32 here should
be an __be32 because it is a big endian on-disk format. Why
would you change only a single field?
Because that's all I needed, and wanted to avoid excess patch churn. Plus
(appeal to authority here :-)) it's in keeping with what Al Viro did when
the __be32 annotations were first added.
I can change all __u32 to __be32 and drop the comment if that's preferred.
That would be great!
I totally agree with Christoph.
Thanks - now there's two __s32 fields in that header - one checksum each
for RDB and PB. No one has so far seen the need for a 'signed big endian
32 bit' type, and I'd rather avoid adding one to types.h. I'll leave
those as they are (with the tacit understanding that they are equally
meant to be big endian).
Cheers,
Michael
Gr{oetje,eeting}s,
Geert
