Hi Christoph,
thanks for your comments!
Am 15.06.2023 um 16:17 schrieb Christoph Hellwig:
On Thu, Jun 15, 2023 at 03:08:36PM +1200, Michael Schmitz wrote:
+/* MSch 20230615: any field used by the Linux kernel must be
+ * annotated __be32! If any fields require increase to 64
+ * bit size, rdb_ID _must_ be changed!
+ */
This is a really weird comment. If you change on-disk format it
is a different format and needs to be marked as such, sure.
I concede this isn't relevant to the matter at hand, and it's something
that _should_ be obvious. This came up in my off-list discussion with
Joanne Dow as a caveat for future huge disk sizes, so I thought I'd add
it to the comment.
And as far as I can tell everything that is a __u32 here should
be an __be32 because it is a big endian on-disk format. Why
would you change only a single field?
Because that's all I needed, and wanted to avoid excess patch churn.
Plus (appeal to authority here :-)) it's in keeping with what Al Viro
did when the __be32 annotations were first added.
I can change all __u32 to __be32 and drop the comment if that's preferred.
Cheers,
Michael
