Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Damien Le Moal <dlemoal@xxxxxxxxxx>
Subject: Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 May 2023 02:21:36 -0700
Cc: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>, Pradeep P V K <quic_pragalla@xxxxxxxxxxx>, axboe@xxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "yukuai (C)" <yukuai3@xxxxxxxxxx>
In-reply-to: <a2f86cd7-776c-d7ed-8815-62683a14ba36@kernel.org>
References: <20230517084434.18932-1-quic_pragalla@quicinc.com> <07b8b870-a464-25a9-c0a6-c123fad05ff5@huaweicloud.com> <a2f86cd7-776c-d7ed-8815-62683a14ba36@kernel.org>

On Wed, May 17, 2023 at 06:20:19PM +0900, Damien Le Moal wrote:
> twice for the same icq. The missing rcu lock in ioc_exit_icqs() already was in
> itself a bug, and the missing flag check is another.

spinlocks imply a rcu critical section, no need to duplicate it.

Follow-Ups:
- Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
  - From: Damien Le Moal

References:
- [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
  - From: Pradeep P V K
- Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
  - From: Yu Kuai
- Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
  - From: Damien Le Moal

Prev by Date: Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
Next by Date: Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
Previous by thread: Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
Next by thread: Re: [PATCH V1] block: Fix null pointer dereference issue on struct io_cq
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]