On 02/02/2017 03:58 AM, Greg Kroah-Hartman wrote: > On Wed, Feb 01, 2017 at 12:31:15AM -0800, Omar Sandoval wrote: >> On Wed, Feb 01, 2017 at 09:16:08AM +0100, Greg Kroah-Hartman wrote: >>> On Tue, Jan 31, 2017 at 02:53:16PM -0800, Omar Sandoval wrote: >>>> From: Omar Sandoval <osandov@xxxxxx> >>>> >>>> When I moved the blk-mq debugging information to debugfs, I didn't >>>> realize that blktrace also created directories in debugfs that >>>> conflicted with the blk-mq directories. This series fixes that. >>>> >>>> Patch 1 adds a new debugfs helper needed for patch 6. Greg, could I get >>>> an ack on that if it makes sense? Jens and I went back and forth on this >>>> for a little while, but patch 6 has more of the rationale on why we >>>> decided that this approach was the cleanest. >>> >>> I can't find patch 6, you only cc:ed me on the first patch :( >>> >>> Care to bounce them all to me? >>> >>> thanks, >>> >>> greg k-h >> >> Gah, I forgot --cc-cover to git-send-email. The series is all here: >> http://marc.info/?l=linux-block&r=1&b=201701&w=2. I can also send the >> patches directly to you if you prefer that. > > I don't understand the problem here. How do you not know if you have > created the debugfs file or not? You have the structure, with the > correct name, how could it have been created? Can't you save the dentry > to the debugfs file in the structure that has the name? The problem is that blktrace registers a trace name directory, which can be either whole device or partition, depending on what you trace. For the blk-mq debug parts, we always just register the whole device name. There's no way to save the partition dentry, and imho, why even would you when you can just look it up. It's a file system... -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
