On Fri, Jan 27, 2017 at 10:00:19PM +0000, Bart Van Assche wrote:
> On Wed, 2017-01-25 at 08:06 -0800, Omar Sandoval wrote:
> > +static void *hctx_dispatch_start(struct seq_file *m, loff_t *pos)
> > +{
> > + struct blk_mq_hw_ctx *hctx = m->private;
> > +
> > + spin_lock(&hctx->lock);
> > + return seq_list_start(&hctx->dispatch, *pos);
> > +}
> > [ ... ]
> > +static void hctx_dispatch_stop(struct seq_file *m, void *v)
> > +{
> > + struct blk_mq_hw_ctx *hctx = m->private;
> > +
> > + spin_unlock(&hctx->lock);
> > +}
> > [ ... ]
> > +static void *ctx_rq_list_start(struct seq_file *m, loff_t *pos)
> > +{
> > + struct blk_mq_ctx *ctx = m->private;
> > +
> > + spin_lock(&ctx->lock);
> > + return seq_list_start(&ctx->rq_list, *pos);
> > +}
> > [ ... ]
> > +static void ctx_rq_list_stop(struct seq_file *m, void *v)
> > +{
> > + struct blk_mq_ctx *ctx = m->private;
> > +
> > + spin_unlock(&ctx->lock);
> > +}
>
> Please add __acquires() / __releases() annotations to these functions as
> appropriate to keep sparse happy.
>
> Thanks,
>
> Bart.
Hey, Bart,
Jens pulled these in to his for-4.11/block branch already, could you
send these comments as incremental patches?
Thanks for taking a look!
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
