Re: [PATCH 3/3] irq-poll: Reduce local_irq_save/restore operations in irq_poll_softirq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+	while (!list_empty(&list)) {

Maybe do a list_first_entry_or_null here if you're touching the list
iteration anyway?

I can do that.

+	local_irq_disable();
+	list_splice_tail_init(iop_list, &list);
+	list_splice(&list, iop_list);
+
 	if (rearm)
 		__raise_softirq_irqoff(IRQ_POLL_SOFTIRQ);

Maybe check if we have a non-empty list before disabling irqs?

Which list? the local list? do in case the local list is empty
but iop_list isn't another irq_poll_sched() already raised a
softirq?

Also that list_emtpy check can replace the rearm condition - we only
set the rearm flag if we break with a non-empty local list now.

You're right.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux