Re: [PATCH 2/3] irq-poll: micro optimize some branch predictions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Are they really that unlikely?  I don't like these annotations unless
it's clearly an error path or they have a high, demonstrable benefit.

IRQ_POLL_F_DISABLE is set when disabling the iop (in the end of the
world). IRQ_POLL_F_SCHED is set on irq_poll_sched() itself so this cond
would match only if the user called irq_poll_sched() twice which it
shouldn't ever do.

So yes, I think these are really unlikely()

But now I noticed that I typo'ed the IRQ_POLL_F_SCHED from
unlikely to likely :(

need to fix that...
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux