>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: Christoph> We can move the sanity checks out. Or even better get rid of Christoph> the stupid behavior of ignoring the late -EOPNOTSUPP in this Christoph> low level helper and instead leaving it to the caller(s) that Christoph> care. It definitely should be a caller decision whether to ignore the return value or not. >> I am OK with your patch as a stable fix but this really needs to be >> fixed up properly. Christoph> And I'd much prefer to get this right now. It's not like Christoph> this is recently introduced behavior. Unfortunately there are quite a few callers of blkdev_issue_discard() these days. Some of them ignore the return value but not all of them. I'm concerned about causing all sorts of breakage if we suddenly start returning errors various places in the stable trees. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
