On 11/09/2015 11:52 AM, Matthew Wilcox wrote:
> On Sun, Nov 08, 2015 at 02:27:39PM -0500, Dan Williams wrote:
>> As Dave points out when dealing with the contents of a page we use
>> PAGE_SIZE and PAGE_SHIFT, similary for huge pages use HPAGE_SIZE and
>> HPAGE_SHIFT.
>
> Hang on, no. We want to use PMD_SIZE here so that when we add PGD_SIZE
> support, it's all nicely symmetrical.
This is splitting hairs a bit, but here goes.
Do we care about the pagetables, or do we care about the page sizes?
If we are doing pagetable things, we use P{TE,MD,UD,GD}_SIZE. If we are
doing something related to page (contents) themselves, we use
H?PAGE_SIZE. This makes it clear whether we're dealing with pagetables,
or *contents*.
In the end, they're the same thing on our architecture at the moment, so
it matters very little.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
