Re: [PATCH 1/4] bcache: remove the cache_dev_name field from struct cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/21 11:35 PM, Christoph Hellwig wrote:
On Mon, Oct 18, 2021 at 11:32:26PM +0800, Coly Li wrote:
It was in Linux v4.17 time, when I did the device failure handling. If the
underlying device broken and gone, printing the device name string will be
a "null" string in kmesg. But the device name was necessary for proper
device failure information, we stored the device name string when it was
initialized.
I'm pretty sure that was before the %pg specifier and the
hd_struct/block_device unification.  With the current code there is no
way it could print null.

Cool. Please add my acked-by to the first 2 patches,

Acked-by: Coly Li <colyli@xxxxxxx>

Thanks for the hint.

Coly Li



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux ARM Kernel]     [Linux Filesystem Development]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux