On 10/18/21 11:21 PM, Christoph Hellwig wrote:
On Mon, Oct 18, 2021 at 10:26:18PM +0800, Coly Li wrote:
On 10/18/21 2:09 PM, Christoph Hellwig wrote:
Just use the %pg format specifier to print the name directly.
Hi Christoph,
NACK for this patch. The buffer cache_dev_name is added on purpose, in
case ca->bdev cannot be referenced correctly for some special condition
when underlying device fails.
Where exactly? ->bdev is never cleared and only dropped after we
waited for the I/O to complete.
It was in Linux v4.17 time, when I did the device failure handling. If
the underlying device broken and gone, printing the device name string
will be a "null" string in kmesg. But the device name was necessary for
proper device failure information, we stored the device name string when
it was initialized.
Coly Li