-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2019/3/22 4:18 下午, Dennis Schridde wrote: > On Freitag, 22. März 2019 08:04:20 CET Coly Li wrote: >> On 2019/3/22 2:14 下午, Coly Li wrote: >>> On 2019/3/21 10:16 下午, Coly Li wrote: >>>> Now I am able to understand your patch. Yes this patch may >>>> fix one of the condition that jset get lost. >>>> >>>> We should have this fix in v5.1, I will handle the format >>>> issue. And if you don't mind I may re-compose a commit log to >>>> explain what exactly is fixed. >>> >>> When I review the patch, I feel there is one point I still do >>> not understand, could you please give me more hint ? >>> >>> From your commit log, "so when we doing replay, journals from >>> last_seq_wrote to last_seq_now are missing.", can you show me >>> the code to explain how such condition happens ? >> >> Aha, I realize this is for discard enabled condition. Hmm, but >> discard is disabled by default. >> >> Hi Dennis, >> >> Is discard enabled in your environment ? Or it is just disabled >> by default. > > How do I figure that out? (I currently only have access to /etc, > my previous 4.18 or 4.19 kernel build config and whatever metadata > bcache tools can provide me with.) Hi Dennis, The sysfs interface is /sys/fs/bcache/<cacheset UUID>/cache0/discard By default it should be 0 (disabled). - -- Coly Li -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE6j5FL/T5SGCN6PrQxzkHk2t9+PwFAlyUm34ACgkQxzkHk2t9 +PyhJhAAiA73GC7DH+W/adm5EWzLXdfIyPrhELLYGvhyaw4A7Us85COO7alJuNXF /Z5EMV815dgAMv1KpDUrhpQ4B3jBRGK5p+6Z5HUX8WwucAtF0Qpxj7UV+JAyH95U +AtZswUDhFAtq/A6AKRoNOCaUjp63t/JawYSMbiz9fB0+F89l9oc4ur43kc4O7jV mod2t6eKYNUd4UAKaaKI8JlSXZHoj6ZkehiodLzJ0tFPQq2HRsfPLh4yW4Po62PK zr/kHVqWfRqvMiu8DAbk7DXNl5dB2YisaMSgGqBod6/vJmFP3QkTFIVeUyJ0YmU1 D8+2cJF4F3i2ZoSVL/LrTWVRscWwkyeH8wundKuMeC+XpDzDLzGsjgsC+Ac06vJC VTZ6d3gIiPSOvlcs9MBkU+9qYu494biQuHHvlxFx0IUy97tvoU+AInUiG1eZvzJ5 82u3feBVSBuwClSB0ByFqcgmdb+8ptX5TsoQ+HNhvsD1VWOPTtJPI5TUCJdQWD/F wZ7sY5nQP3WthdX+sOnidwzucpC0pQdmB3PerNoD9fbT4H556kPNhCpc/NIjYuUc aiAdmNK6KcbPCpDmbxK+drh7jFojtF5m/sDDNZgYPS76UD2WQGulrIYJnGhMMkCZ jBX/aeA1o3GKR5JUQZJKwEHnxJq0pS2fCVgx9wbZMCSRhhyurU8= =Vy47 -----END PGP SIGNATURE-----
