On Freitag, 22. März 2019 08:04:20 CET Coly Li wrote: > On 2019/3/22 2:14 下午, Coly Li wrote: > > On 2019/3/21 10:16 下午, Coly Li wrote: > >> Now I am able to understand your patch. Yes this patch may fix one of > >> the condition that jset get lost. > >> > >> We should have this fix in v5.1, I will handle the format issue. And if > >> you don't mind I may re-compose a commit log to explain what exactly is > >> fixed. > > > > When I review the patch, I feel there is one point I still do not > > understand, could you please give me more hint ? > > > > From your commit log, "so when we doing replay, journals from > > last_seq_wrote to last_seq_now are missing.", can you show me the code > > to explain how such condition happens ? > > Aha, I realize this is for discard enabled condition. Hmm, but discard > is disabled by default. > > Hi Dennis, > > Is discard enabled in your environment ? Or it is just disabled by default. How do I figure that out? (I currently only have access to /etc, my previous 4.18 or 4.19 kernel build config and whatever metadata bcache tools can provide me with.) --Dennis
Attachment:
signature.asc
Description: This is a digitally signed message part.
