On 2018/8/10 10:52 AM, shenghui wrote:
>
>
> On 08/09/2018 02:43 PM, Coly Li wrote:
>> kmem_cache_destroy() is safe for NULL pointer as input, the NULL pointer
>> checking is unncessary. This patch just removes the NULL pointer checking
>> to make code simpler.
>>
>> Signed-off-by: Coly Li <colyli@xxxxxxx>
>> ---
>> drivers/md/bcache/request.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
>> index 449baec3fa19..4bdcec9167a0 100644
>> --- a/drivers/md/bcache/request.c
>> +++ b/drivers/md/bcache/request.c
>> @@ -1367,8 +1367,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
>>
>> void bch_request_exit(void)
>> {
>> - if (bch_search_cache)
>> - kmem_cache_destroy(bch_search_cache);
>> + kmem_cache_destroy(bch_search_cache);
>> }
>>
>> int __init bch_request_init(void)
>>
>
> Hi Coly,
>
> You change is OK.
>
> But when I grepped the source, I found one kmem_cache declared but not used:
> ----------------------------------
> drivers/md/bcache# grep bch_passthrough_cache *
> request.h:extern struct kmem_cache *bch_search_cache, *bch_passthrough_cache;
>
> Will you please take a look?
Hi Shenghui,
It seems bch_passthrough_cache is not used anywhere since the first
bcache commit. Since you find this issue, would you like to compose and
post a small patch to fix ?
Thanks.
Coly Li
