On 2018/8/10 10:22 AM, shenghui wrote: > > > On 08/09/2018 02:43 PM, Coly Li wrote: >> There are many function definitions do not have identifier argument names, >> scripts/checkpatch.pl complains warnings like this, >> >> WARNING: function definition argument 'struct bcache_device *' should >> also have an identifier name >> #16735: FILE: writeback.h:120: >> +void bch_sectors_dirty_init(struct bcache_device *); > > Hi Coly, > > I found some definition still lack argument names, e.g > static int bch_btree_insert_node(struct btree *, struct btree_op *, > static void bch_data_insert_start(struct closure *); > > But I haven't figure out how to catch all the missing by cmds+re. Hi Shenghui, Thanks, I will update them in v2 series. Coly Li >> >> This patch adds identifier argument names to all bcache function >> definitions to fix such warnings. >> >> Signed-off-by: Coly Li <colyli@xxxxxxx> >> --- >> drivers/md/bcache/bcache.h | 112 +++++++++++++++--------------- >> drivers/md/bcache/bset.h | 126 +++++++++++++++++++--------------- >> drivers/md/bcache/btree.h | 80 ++++++++++----------- >> drivers/md/bcache/debug.h | 6 +- >> drivers/md/bcache/extents.h | 6 +- >> drivers/md/bcache/journal.h | 20 +++--- >> drivers/md/bcache/request.h | 2 +- >> drivers/md/bcache/stats.h | 13 ++-- >> drivers/md/bcache/util.h | 12 ++-- >> drivers/md/bcache/writeback.h | 9 +-- >> 10 files changed, 207 insertions(+), 179 deletions(-) [snipped]
