On 2018/5/4 11:22 PM, Michael Lyle wrote: > Coly--- > Hi Mike, > As long as the actual record as written to disk is checked, there are no > changes needed to CRC code (just a swap afterwards like almost > everything else in the kernel does). I don't think that should block > this commit. Getting it factored to a common place will help bcachefs > and discourage others from choosing crc64 with other polynomials. > "discourage others from choosing crc64 with other polynomials" -- this line hits my heart. I buy your suggestion :-) > If the CRC code does not need to change to support BE host, there seems > to be no issue with this being relocated. > > This was on my to-do list before-- along with other general purpose > stuff like the closure code. It makes me happy that someone has taken > care of it. You convinced me, let me handle the rested stuffs. Thank you for the patience, again. Coly Li -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
