Hi Coly-- On Thu, May 3, 2018 at 7:49 PM, Coly Li <colyli@xxxxxxx> wrote: > On 2018/5/4 3:37 AM, Andy Shevchenko wrote: > I like the idea. So far a problem is endianness, bch_crc64() is for > on-disk format, which means it is always little endian, and lib/crc64.c > should not have such assumption. Further more, almost all the bcache > code assumes the processor is little endian, including the checksum > calculation.And the order to calculate and check checksum in bcache code > should be fixed as well. The result is, so far bcache does not work on > s390x. I don't see where this code has any endian implications, can you please point it out to me? I like the idea of factoring this to the library. Though one issue I see is there's many different CRC64 polynomials. Calling this one "CRC64" may not be appropriate. Mike -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
