Hi Liang-- Thanks for the quick turnaround. I've added this to bcache-for-next. On 10/12/2017 10:30 PM, Liang Chen wrote: > The use of the union reduces the size of closure struct by taking advantage > of the current size of its members. The offset of func in work_struct equals > the size of the first three members, so that work.work_func will just > reference the forth member - fn. > > This is smart but dangerous. It can be broken if work_struct or the other > structs get changed, and can be a bit difficult to debug. > > Signed-off-by: Liang Chen <liangchen.linux@xxxxxxxxx> Reviewed-by: Michael Lyle <mlyle@xxxxxxxx> -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html