On Tue, 1 Mar 2016, Jens Axboe wrote: > On 02/29/2016 06:08 PM, Eric Wheeler wrote: > > Hi Jens, > > > > Can we still get these in for 4.5? One is a race, the other is just error > > handling. > > > > Please pull: > > git pull https://bitbucket.org/ewheelerinc/linux.git > > v4.5-rc6-bcache-fixes > > > > bcache: fix race of writeback thread starting before complete initialization > > bcache: cleaned up error handling around register_cache() > > They look simple enough, though I generally don't like collapsing things like > this: > > if ((ret = cache_alloc(sb, ca)) != 0) > > it's easy to screw up, doing > > ret = cache_alloc(sb, ca); > if (ret != 0) > ... Done. Rebased, fixed, and push --force'ed. BTW, Is there a better (preferred) way vs. push --force? Some say push --force can break things. > > is a lot more readable and harder to screw up. Can we get that cleaned up? We > can still make 4.5, I've got a bunch pending that's going out today, and these > two would have missed the boat for today anyway. But that doesn't mean we > can't get them out later this week. Thanks! -Eric > -- > Jens Axboe > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-bcache" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
