Hi,
On 18/11/2021 02:27, Bjorn Andersson wrote:
On Sun 31 Oct 10:56 CDT 2021, Christian Lamparter wrote:
From: Pavel Kubelun <be.dissent@xxxxxxxxx>
It seems like sleep_clk was copied from ipq806x.
Fix ipq40xx sleep_clk to the value QSDK defines.
Also rename the sleep clock node like the GCC driver names it.
Link: https://source.codeaurora.org/quic/qsdk/oss/kernel/linux-msm/commit/?id=d92ec59973484acc86dd24b67f10f8911b4b4b7d
Link: https://patchwork.kernel.org/comment/22721613/
Signed-off-by: Pavel Kubelun <be.dissent@xxxxxxxxx>
Signed-off-by: Christian Lamparter <chunkeey@xxxxxxxxx> (resend)
---
arch/arm/boot/dts/qcom-ipq4019.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
index 7a181352b306..ed40bef91e45 100644
--- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
@@ -144,9 +144,9 @@ pmu {
};
clocks {
- sleep_clk: sleep_clk {
+ sleep_clk: gcc_sleep_clk_src {
Underscore is not a valid character in node names, so it should named
something like sleep-clk.
Ok, this is a bit awkward. The current DeviceTree Specification 0.3v list
the "underscore" in "Table 2.1: Valid characters for node names". (Page 7)
<https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf>
But...
It would be nice if the clock driver was converted to using parent_data
and fw_name and a clocks reference in the gcc node to &sleep_clk, but if
you need something that works with the current implementation then
clock-output-names = "gcc_sleep_clk_src"; >
is your friend.
But please do consider converting the gcc-ipq4019.c to acquire "xo" and
"sleep_clk" using parent_data instead.
Yes, I think this could be done. Next month around the seasonal holidays,
I do think there will be some free time to run this on the IPQ40xx devices
that would otherwise be blinking away lonely at the office. (Pavel's patch
has been here so long that I knew it is "working".)
So the next series will be:
- change this patch to just fix the clock-frequency value.
- another new patch that updates gcc-ipq4019.c code
replace all the parent_name with "xo" and "gcc_sleep_clk_src"
with parent_data + fw_name (in the same way in which
gcc-ipq6018.c seems to be doing it).
Is there anything I missed?
(I could throw in the sleep_clk -> sleep(-clk) change as well.
But I'll need find a justification for replacing "_" vs "-" there,
since I can't really lean on the Device-Tree spec since it
proclamates that the underscore is a "valid character"?!)
Thanks,
Christian
