On Sun 31 Oct 10:56 CDT 2021, Christian Lamparter wrote: > From: Pavel Kubelun <be.dissent@xxxxxxxxx> > > It seems like sleep_clk was copied from ipq806x. > Fix ipq40xx sleep_clk to the value QSDK defines. > > Also rename the sleep clock node like the GCC driver names it. > > Link: https://source.codeaurora.org/quic/qsdk/oss/kernel/linux-msm/commit/?id=d92ec59973484acc86dd24b67f10f8911b4b4b7d > Link: https://patchwork.kernel.org/comment/22721613/ > Signed-off-by: Pavel Kubelun <be.dissent@xxxxxxxxx> > Signed-off-by: Christian Lamparter <chunkeey@xxxxxxxxx> (resend) > --- > arch/arm/boot/dts/qcom-ipq4019.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi > index 7a181352b306..ed40bef91e45 100644 > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi > @@ -144,9 +144,9 @@ pmu { > }; > > clocks { > - sleep_clk: sleep_clk { > + sleep_clk: gcc_sleep_clk_src { Underscore is not a valid character in node names, so it should named something like sleep-clk. It would be nice if the clock driver was converted to using parent_data and fw_name and a clocks reference in the gcc node to &sleep_clk, but if you need something that works with the current implementation then clock-output-names = "gcc_sleep_clk_src"; is your friend. But please do consider converting the gcc-ipq4019.c to acquire "xo" and "sleep_clk" using parent_data instead. Regards, Bjorn > compatible = "fixed-clock"; > - clock-frequency = <32768>; > + clock-frequency = <32000>; > #clock-cells = <0>; > }; > > -- > 2.33.1 >
