On 15-11-21, 23:38, quic_vamslank@xxxxxxxxxxx wrote:
> From: Vamsi Krishna Lanka <quic_vamslank@xxxxxxxxxxx>
>
> Add Global Clock Controller (GCC) support for SDX65 SoCs from Qualcomm.
>
> Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@xxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
Missing support reported ??
> +static struct clk_branch gcc_ahb_pcie_link_clk = {
> + .halt_reg = 0x2e004,
> + .halt_check = BRANCH_HALT,
> + .clkr = {
> + .enable_reg = 0x2e004,
> + .enable_mask = BIT(0),
> + .hw.init = &(struct clk_init_data){
> + .name = "gcc_ahb_pcie_link_clk",
> + .flags = CLK_IS_CRITICAL,
> + .ops = &clk_branch2_ops,
> + },
If this clk is critical then why model in linux, enable directly in probe
and leave it...?
> +static struct clk_branch gcc_pcie_0_clkref_en = {
> + .halt_reg = 0x88004,
> + .halt_check = BRANCH_HALT_DELAY,
Why delay, add a comment at least for that
> + .clkr = {
> + .enable_reg = 0x88004,
> + .enable_mask = BIT(0),
> + .hw.init = &(struct clk_init_data){
> + .name = "gcc_pcie_0_clkref_en",
> + .ops = &clk_branch2_ops,
> + },
> + },
> +};
> +
> +static struct clk_branch gcc_pcie_aux_clk = {
> + .halt_reg = 0x43034,
> + .halt_check = BRANCH_HALT_DELAY,
Here too
> +static struct clk_branch gcc_pcie_mstr_axi_clk = {
> + .halt_reg = 0x43024,
> + .halt_check = BRANCH_HALT_VOTED,
> + .hwcg_reg = 0x43024,
> + .hwcg_bit = 1,
> + .clkr = {
> + .enable_reg = 0x6d010,
> + .enable_mask = BIT(1),
> + .hw.init = &(struct clk_init_data){
> + .name = "gcc_pcie_mstr_axi_clk",
> + .ops = &clk_branch2_ops,
> + },
> + },
> +};
> +
> +static struct clk_branch gcc_pcie_pipe_clk = {
> + .halt_reg = 0x4303c,
> + .halt_check = BRANCH_HALT_DELAY,
here as well and few more places I guess
> +static struct clk_branch gcc_xo_pcie_link_clk = {
> + .halt_reg = 0x2e008,
> + .halt_check = BRANCH_HALT,
> + .hwcg_reg = 0x2e008,
> + .hwcg_bit = 1,
> + .clkr = {
> + .enable_reg = 0x2e008,
> + .enable_mask = BIT(0),
> + .hw.init = &(struct clk_init_data){
> + .name = "gcc_xo_pcie_link_clk",
> + .flags = CLK_IS_CRITICAL,
Here as well
--
~Vinod
