Re: [PATCH v2 2/3] arm64: dts: qcom: msm8916-asus-z00l: Add SDCard

[Stephan Gerhold <stephan@xxxxxxxxxxx>]

On Tue, Oct 12, 2021 at 04:57:34PM +0530, J.R. Divya Antony wrote:
> Enable SDHCI (SD Card) Storage.
> 
> Signed-off-by: J.R. Divya Antony <d.antony.jr@xxxxxxxxx>

Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx>

> ---
>  .../arm64/boot/dts/qcom/msm8916-asus-z00l.dts | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts b/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts
> index 71f4aa16058f..355c95365fcd 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts
> @@ -42,6 +42,21 @@ volume-down {
>  		};
>  	};
>  
> +	reg_sd_vmmc: regulator-sdcard-vmmc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "sdcard-vmmc";
> +		regulator-min-microvolt = <2950000>;
> +		regulator-max-microvolt = <2950000>;
> +
> +		gpio = <&msmgpio 87 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		startup-delay-us = <200>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&sd_vmmc_en_default>;
> +	};
> +
>  	usb_id: usb-id {
>  		compatible = "linux,extcon-usb-gpio";
>  		id-gpios = <&msmgpio 110 GPIO_ACTIVE_HIGH>;
> @@ -89,6 +104,16 @@ &sdhc_1 {
>  	pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>;
>  };
>  
> +&sdhc_2 {
> +	status = "okay";
> +	vmmc-supply = <&reg_sd_vmmc>;
> +
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
> +	pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
> +	cd-gpios = <&msmgpio 38 GPIO_ACTIVE_LOW>;
> +};
> +
>  &usb {
>  	status = "okay";
>  	extcon = <&usb_id>, <&usb_id>;
> @@ -210,6 +235,14 @@ gpio_keys_default: gpio-keys-default {
>  		bias-pull-up;
>  	};
>  
> +	sd_vmmc_en_default: sd-vmmc-en-default {
> +		pins = "gpio87";
> +		function = "gpio";
> +
> +		drive-strength = <2>;
> +		bias-disable;
> +	};
> +
>  	touchscreen_default: touchscreen-default {
>  		pins = "gpio13";
>  		function = "gpio";
> -- 
> 2.33.0
>