>> + >> + tcsr_mutex: hwlock@1f40000 { >> + compatible = "qcom,tcsr-mutex"; >> + reg = <0x0 0x01f40000 0x0 0x40000>; >> + #hwlock-cells = <1>; >> + }; >> + >> + pdc: interrupt-controller@b220000 { >> + compatible = "qcom,sm6350-pdc", "qcom,pdc"; >> + reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x64>; > > The second reg 0x17c000f0 is neither documented nor used in PDC irq chip driver. can you please remove it? > > Thanks, > Maulik > Wouldn't it make more sense to keep it (like in other PDC-enabled SoCs' device trees) so that there's no need to add it back when the driver gains support for spi_configure_type (I believe that's what it's used for)? Konrad