Quoting mkrishn@xxxxxxxxxxxxxx (2021-03-26 03:36:30) > On 2021-03-26 04:28, Stephen Boyd wrote: > > Quoting Krishna Manikandan (2021-03-25 05:01:00) > >> diff --git > >> a/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > >> b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > >> new file mode 100644 > >> index 0000000..4a26bef > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > >> @@ -0,0 +1,68 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/display/msm/dsi-phy-10nm.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Qualcomm Display DSI 10nm PHY > >> + > >> +maintainers: > >> + - Krishna Manikandan <mkrishn@xxxxxxxxxxxxxx> > >> + > >> +allOf: > >> + - $ref: dsi-phy-common.yaml# > >> + > >> +properties: > >> + compatible: > >> + oneOf: [..] > >> and > >> + connected to VDDA_MIPI_DSI_0_PLL_0P9 pin for sdm845 target > >> + > >> +required: > >> + - compatible > >> + - reg > >> + - reg-names > >> + - vdds-supply > >> + > >> +unevaluatedProperties: false > > > > additionalProperties: false instead? This comment applies to the other > > bindings in this patch. > > Hi Stephen, > We are referencing dsi-phy-common.yaml in this file. Since the > properties of dsi-phy-common.yaml are applicable to this file also, I > added unevaluatedProperties: false. If we add additionalProperties: > false instead, then the properties of dsi-phy-common.yaml will not be > applicable here and this will throw an error if we add the properties > from dsi-phy-common.yaml in the example. > Does that matter? I was wondering about that and so I peeked at the qcom pinctrl binding and it seems to follow a similar design but doesn't have unevaluatedProperties: false. Instead it has additionalProperies: false. See qcom,sc8180x-pinctrl.yaml for an example. So did you try it or does something say you can't do this?
