Quoting Krishna Manikandan (2021-02-12 02:49:59) > Add YAML schema for the device tree bindings for DSI PHY. > > Signed-off-by: Krishna Manikandan <mkrishn@xxxxxxxxxxxxxx> > > Changes in v1: > - Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd) > - Remove qcom,dsi-phy-regulator-ldo-mode (Stephen Boyd) > - Add clock cells properly (Stephen Boyd) > - Remove unnecessary decription from clock names (Stephen Boyd) > - Add pin names for the supply entries for 10nm phy which is > used in sc7180 and sdm845 (Stephen Boyd) > - Remove unused header files from examples (Stephen Boyd) > - Drop labels for display nodes and correct node name (Stephen Boyd) > > Changes in v2: > - Drop maxItems for clock (Stephen Boyd) > - Add vdds supply pin information for sdm845 (Stephen Boyd) > - Add examples for 14nm, 20nm and 28nm phy yaml files (Stephen Boyd) > - Keep child nodes directly under soc node (Stephen Boyd) > --- > .../bindings/display/msm/dsi-phy-10nm.yaml | 85 +++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-14nm.yaml | 83 ++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-20nm.yaml | 88 ++++++++++++++++++++++ > .../bindings/display/msm/dsi-phy-28nm.yaml | 84 +++++++++++++++++++++ Aren't these bindings largely the same modulo the compatible string? Can we either combine them into one document or use a common binding base that is imported into the different nanometer phy binding docs? Look at Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml for how this was done for the qcom pinctrl binding. >From a quick glance, the compatible string and the supply name is different. Otherwise it's the same? Please combine them together. > 4 files changed, 340 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-20nm.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml >
